Skip to content

synchronize(dex): bump Dex manifests to v2.45.0#3364

Merged
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
danish9039:sync/dex-next
Mar 1, 2026
Merged

synchronize(dex): bump Dex manifests to v2.45.0#3364
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
danish9039:sync/dex-next

Conversation

@danish9039

@danish9039 danish9039 commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

✏️ Summary of Changes

  • Bump Dex sync script pin to v2.45.0
  • Regenerate Dex image tag in common/dex/base/deployment.yaml
  • Update Dex version entry in root README.md

📦 Dependencies

  • None

🐛 Related Issues

  • Follow-up component sync after cert-manager sync script updates

✅ Contributor Checklist

  • I have tested these changes with kustomize.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page.

Copilot AI review requested due to automatic review settings February 27, 2026 02:34
@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI reviewed Feb 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned Dex version used by the repository’s synchronization workflow and the checked-in manifests/documentation to Dex v2.45.0.

Changes:

  • Bump scripts/synchronize-dex-manifests.sh to target Dex release v2.45.0.
  • Update Dex Deployment image tag to ghcr.io/dexidp/dex:v2.45.0.
  • Update the root README component/version table entry for Dex to 2.45.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
scripts/synchronize-dex-manifests.sh Updates the Dex release pin used by the sync automation.
common/dex/base/deployment.yaml Updates the Dex container image tag to v2.45.0.
README.md Updates documented Dex version/link to v2.45.0.

Comment thread scripts/synchronize-dex-manifests.sh Outdated
@juliusvonkohout

juliusvonkohout commented Feb 27, 2026

Copy link
Copy Markdown
Member

Please check https://github.com/dexidp/dex/blob/master/examples/k8s/dex.yaml, why the tests are failing and whether 2 replicas would also work.

@juliusvonkohout

juliusvonkohout commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you for the PR. Please check also whether https://github.com/danish9039/manifests/blob/sync/dex-next/common/dex/base/crds.yaml should be updated. And adjust the script to do so if needed.

@juliusvonkohout

juliusvonkohout commented Feb 27, 2026

Copy link
Copy Markdown
Member

Please also rebase to master, the new copilot instructions should block pr titles that say sync instead of synchronisation

@juliusvonkohout juliusvonkohout changed the title sync(dex): bump Dex manifests to v2.45.0 synchronize(dex): bump Dex manifests to v2.45.0 Feb 27, 2026
Copilot AI review requested due to automatic review settings February 28, 2026 08:41
@google-oss-prow google-oss-prow Bot added size/L and removed size/XS labels Feb 28, 2026
Copilot AI reviewed Feb 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread scripts/synchronize-dex-manifests.sh Outdated
Comment thread README.md Outdated
Copilot AI review requested due to automatic review settings February 28, 2026 08:48
Copilot AI reviewed Feb 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread scripts/synchronize-dex-manifests.sh Outdated
@danish9039

danish9039 commented Feb 28, 2026

Copy link
Copy Markdown
Member Author

@juliusvonkohout I checked the Dex v2.45.0 failure locally,

first blocking issue was not replicas. The new Dex imagev2.45.0 now runs as named user dex:dex, while our deployment keeps runAsNonRoot: true without a numeric UID/GID. Kubernetes then rejects the pod with CreateContainerConfigError because it cannot verify that the named image user is non-root, so i have added numeric runAsUser: 1001 and runAsGroup: 1001 , and the Dex login flow passed

juliusvonkohout
juliusvonkohout reviewed Feb 28, 2026
View reviewed changes
Comment thread scripts/synchronize-dex-manifests.sh Outdated
@google-oss-prow google-oss-prow Bot added size/S and removed size/L labels Mar 1, 2026
@danish9039 danish9039 mentioned this pull request Mar 1, 2026
Merged
3 tasks
@danish9039
sync(dex): bump Dex manifests to v2.45.0
9b9422f 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
dex: set numeric runAs user
ad3e681 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
dex: keep sync script executable
a2d7e82 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@juliusvonkohout

juliusvonkohout commented Mar 1, 2026

Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Mar 1, 2026
@google-oss-prow

google-oss-prow Bot commented Mar 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 005fa3d into kubeflow:master Mar 1, 2026
8 checks passed
@danish9039 danish9039 mentioned this pull request Mar 3, 2026
Merged
Raakshass added a commit to Raakshass/manifests that referenced this pull request Mar 27, 2026
@Raakshass
synchronize(dex): bump Dex manifests to v2.45.0 (kubeflow#3364)
da7f6f0 
* sync(dex): bump Dex manifests to v2.45.0

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

* dex: set numeric runAs user

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

* dex: keep sync script executable

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

---------

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 mentioned this pull request Apr 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout juliusvonkohout left review comments

Copilot code review Copilot Copilot left review comments

@tarekabouzeid tarekabouzeid Awaiting requested review from tarekabouzeid

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danish9039 @juliusvonkohout